On Mon, Jan 12, 2009 at 06:32:45PM +0000, Richard W.M. Jones wrote: > On Mon, Dec 15, 2008 at 09:38:52PM +0000, Daniel P. Berrange wrote: > > On Mon, Dec 15, 2008 at 11:58:06AM -0800, john.levon@xxxxxxx wrote: > > > # HG changeset patch > > > # User john.levon@xxxxxxx > > > # Date 1229367890 28800 > > > # Node ID 6a8e82d7d2e166880fed8d7ad860a3e2e93d62be > > > # Parent c324c231c6a50be9f970f0f6c6d1629a7c09ab3b > > > Avoid GCC extensions > > > > > > Anonymous unions are not portable, nor are zero-sizes structures. > > > > ACK. Shame there's no GCC flag to warn about this non-portability. > > At least I couldn't find one so far... > > Isn't this what -pedantic does? Possibly, but -pedantic is utterly f*ing useless because of all the line noise it generates about use of 'long long', trailing commas in enums, use of variadic macros, and countless other important modern C features Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list