Re: [PATCHv2 4/7] phyp: Fix error messages mentioning memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 25, 2015 at 11:22:03AM +0100, Peter Krempa wrote:
The messages for currentMemory and memory were swapped.
---

Notes:
   Version 2:
   - new in series

src/phyp/phyp_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index c1d6eb2..a1e390d 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -3488,14 +3488,14 @@ phypBuildLpar(virConnectPtr conn, virDomainDefPtr def)

    if (!def->mem.cur_balloon) {
        virReportError(VIR_ERR_XML_ERROR, "%s",
-                       _("Field <memory> on the domain XML file is missing or has "
+                       _("Field <currentMemory> on the domain XML file is missing or has "
                         "invalid value."));

You could've wrapped the message to fit into 80 columns and remove the
dot at the and as well.  ACK with that changed.

        goto cleanup;
    }

    if (!virDomainDefGetMemoryInitial(def)) {
        virReportError(VIR_ERR_XML_ERROR, "%s",
-                       _("Field <currentMemory> on the domain XML file is missing or "
+                       _("Field <memory> on the domain XML file is missing or "

ditto

                         "has invalid value."));
        goto cleanup;
    }
--
2.2.2

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: pgp88aLIL9xBS.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]