On Wed, Feb 25, 2015 at 06:09:42AM -0700, Eric Blake wrote: > On 02/25/2015 12:20 AM, Martin Kletzander wrote: > > On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote: > >> On 02/24/2015 09:00 AM, Eric Blake wrote: > >>> Needed to silence a valgrind detection of uninitialized memory: > >>> https://bugzilla.redhat.com/show_bug.cgi?id=1174147 > >>> > >>> * .gnulib: Update to latest. > >>> * bootstrap: Resync to gnulib. > >>> > >>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > >>> --- > >>> > >>> I've missed RC1, so I'll wait for a review on this one (are we sure > >>> that RC2 will be enough time to ensure the gnulib update doesn't > >>> cause regressions, basically). > >> > > > > Is it worth risking that due to one valgrind warning? I don't > > remember more than maybe one time that gnulib caused a problem, but > > who knows. > > And the valgrind warning is harmless - it's complaining about passing > uninitialized memory to a syscall, but that memory lives in the padding > of a struct, and none of the code is actually acting on that memory > (either on our side, or in the syscall). If we want to just live with > the warning until after the release, that would also be okay - we have > up until the RC2 date to make the decision. > > > > > Anyway, "my limited testing" didn't show any problems. > > > >> The gnulib changelog: > > Most of the changes here are for Android, but I don't know of anyone > building libvirt on that platform yet. That said,... > > >> > >> * .gnulib c27f1a3...8be5f2c (75): > >> > passfd: avoid valgrind uninitalised data warning > > This one fixes the valgrind warning... > > >> > gnulib-tool: fix handling of patch(1) diagnostics > >> > bootstrap: exit immediately upon gnulib-tool failure > > these two are useful to us as developers, but don't affect the code base... > > >> > count-leading-zeros: use 64-bit intrinsics on 32-bit Windows > >> > count-leading-zeros: fix pragma typos > > and these might affect mingw builds. > > Any other opinions? >From the list of changes I don't see any compelling reason to push it before release. ie, we're not waiting for any particular bug fix it includes. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list