Re: [PATCHv4 02/10] conf: support backend domain name in disk and network devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/19/2015 08:22 PM, Marek Marczykowski-Górecki wrote:
> From: Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> 
> At least Xen supports backend drivers in another domain (aka "driver
> domain"). This patch introduces XML config option for such setting as
> 'domain' attribute of 'source' element. Verification its content is left
> for the driver.
> 
> In the future same option will be needed for USB devices (hostdev
> objects), but for now libxl doesn't have support for PVUSB.
> 
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> Changes in v2:
>  - describe in docs/formatdomain.html.in
>  - enforce empty domain tag (only 'name' attribute allowed)
> 
> Changes in v3:
>  - change <domain name='xx'/> element to domain='' attribute of source
>    element - this is more logical place
>  - grammar of docs
> 
> Changes in v4:
>  - revert back to separate element, named <backenddomain name='xx'/>

Meta-note (don't feel bad about it this time, but food for thought for
future submissions):

It's a little bit easier on reviewers to send a patch series revision
(in this case, v4) as a new top-level thread rather than buried
in-reply-to an existing thread.  For now, that just seems to be an
unwritten convention on libvirt (the qemu project has actually
documented it: http://wiki.qemu.org/Contribute/SubmitAPatch - but their
policies are sometimes stricter than what we require here, so read that
page with a grain of salt). Of course, a patch to libvirt's HACKING to
make it an explicit convention might not hurt :)


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]