On Mon, Feb 16, 2015 at 19:54:23 +0000, Daniel Berrange wrote: > On Mon, Feb 16, 2015 at 08:50:43PM +0100, Peter Krempa wrote: > > The current balloon setting does not influence the ABI of the guest and > > the driver should take the change just fine. > > --- > > I personally don't think that this check is useful, but I'll happily drop the > > patch if anybody thinks otherwise. > > > > src/conf/domain_conf.c | 6 ------ > > 1 file changed, 6 deletions(-) > > Yes, you can change the balloon target on the fly, so this isn't something > we need to keep as stable across migration. The question though is whether > libvirt/QEMU will correctly handle the changed balloon setting during > migration. ie does libvirt correctly issue a 'balloon' monitor command on > the target host if it has changed in the target XML ? If it does, then I > agree this check can go.. I think qemu should handle this just right as we pass it via the monitor, but I didn't actually try it. I'll hold off this one until I make sure that it actually is okay. Peter
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list