Re: [PATCH 0/3] numatune: Prefer old approach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 12, 2015 at 18:03:50 +0100, Michal Privoznik wrote:
> Consider the following part of domain XML:
> 
>   <numatune>
>    <memory mode='static' nodeset="0,2"/>
>   </numatune>
>   <cpu>
>     <numa>
>       <cell id='0' cpus='0' memory='65536' unit='KiB'/>
>     </numa>
>   </cpu>
> 
> Yes, this have a great potential of breaking things. Especially,
> this will break migration between previous two or three upstream
> releases and current release we are working on, because libvirt
> started domains in more complicated way (even if not needed).
> After these patches, domains will be started in simpler way which
> is incompatible.
> 
> On the other hand, we get backward compatibility with much more
> releases than we are about to break.
> 
> Michal Privoznik (3):
>   numatune_conf: Expose virDomainNumatuneNodeSpecified
>   qemuxml2argvtest: Fake response from numad
>   qemuBuildMemoryBackendStr: Report backend requirement more
>     appropriately

ACK, but see the two nits I found in 3/3.

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]