On Fri, Feb 13, 2015 at 07:55:48AM -0500, Laine Stump wrote:
> On 02/12/2015 04:50 PM, John Ferlan wrote:
> >
> > On 02/09/2015 10:20 AM, Michal Privoznik wrote:
> >> v2
> >>
> >> Michal Privoznik (4):
> >> libvirt_private.syms: Expose virDomainNetTypeFromString
> >> virsh attach-interface: Use enum instead of arbitrary integers
> >> virsh attach-interface: Use virDomainNetType{From,To}String()
> >> virsh attach-interface: Allow macvtap hotplug
> >>
> >> src/libvirt_private.syms | 1 +
> >> tools/virsh-domain.c | 36 ++++++++++++++++++++++++++----------
> >> tools/virsh.pod | 14 ++++++++------
> >> 3 files changed, 35 insertions(+), 16 deletions(-)
> >>
> > ACK series...
>
>
> I had thought that during V1 of this patch series there had been enough
> sentiment about not pulling in private parts of libvirt internals that
> this V2 (posted 2 minutes before the last comment in V1, so very
> literally crossing in the inter-tubes) would be discarded in favor of
> something that only used public APIs - the last word on the subject was
> this:
>
> https://www.redhat.com/archives/libvir-list/2015-February/msg00284.html
>
> (Yes, I know there are other places where it's already done, but it
> seems like a better idea to clean those up than to compound the pollution.)
Yeah, I'd prefer that in general, but this particular patch is only using
the trivial VIR_ENUM string/int conversion, so I'm willing to overlook it
for this. If the internal API being used were non-trivial then I'd say
we should look at the public API support.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list