Re: [PATCH v4 3/3] lxc: Fix container cleanup for LXCProcessStart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 12, 2015 at 03:48:12PM -0500, John Ferlan wrote:
> From: Luyao Huang <lhuang@xxxxxxxxxx>
> 
> Jumping to the cleanup label prior to starting the container failed to
> properly clean everything up that is handled by the virLXCProcessCleanup
> which is called if virLXCProcessStop is called on failure after the
> container properly starts. Most importantly is prior to this patch none
> of the stop/release hooks, host device reattachment, and network cleanup
> (that is reverse of virLXCProcessSetupInterfaces).
> 
> Signed-off-by: Luyao Huang <lhuang@xxxxxxxxxx>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/lxc/lxc_process.c | 78 ++++++++++++++++++++++-----------------------------
>  1 file changed, 33 insertions(+), 45 deletions(-)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]