Re: [PATCH v8 1/4] domifaddr: Implement the public APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 01/25/2015 01:38 PM, Nehal J Wani wrote:
> Define helper function virDomainInterfaceFree, which allows
> the upper layer application to free the domain interface object
> conveniently.
> 

<...snip...>

> diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms
> index 4ea5cff..ab86543 100644
> --- a/src/libvirt_public.syms
> +++ b/src/libvirt_public.syms
> @@ -695,4 +695,10 @@ LIBVIRT_1.2.12 {
>          virDomainDefineXMLFlags;
>  } LIBVIRT_1.2.11;
>  
> +LIBVIRT_1.2.12 {
> +    global:
> +        virDomainInterfaceAddresses;
> +        virDomainInterfaceFree;
> +} LIBVIRT_1.2.13;
> +

Well this is wrong, but I see in patch 2 you've adjusted it.  Since each
patch needs to build/check order wise it'll need to be fixed here

Something I can do assuming the rest of the patches are "OK"...

John

(One of us is going to have a merge forthcoming since I have a new
command series posted today as well).




>  # .... define new API here using predicted next version number ....
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]