[PATCH 5/5] parallels: fix initialization of parallels driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Don't fail initialization of parallels driver even if
parallelsGetBridgedNetInfo fails.  This can happen when
it is unconfigured (which is a common case on developers
hosts for instance) or configured incompletely. In any
case it is not a severe error and we can ignore it and use
only Routed Networks or don't use network at all.
---
 src/parallels/parallels_network.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/parallels/parallels_network.c b/src/parallels/parallels_network.c
index 3e7087d..196d79c 100644
--- a/src/parallels/parallels_network.c
+++ b/src/parallels/parallels_network.c
@@ -214,8 +214,10 @@ parallelsLoadNetwork(parallelsConnPtr privconn, virJSONValuePtr jobj)
     if (STREQ(tmp, "bridged")) {
         def->forward.type = VIR_NETWORK_FORWARD_BRIDGE;
 
-        if (parallelsGetBridgedNetInfo(def, jobj) < 0)
-            goto cleanup;
+        /* We shouldn't fail here because it's not that critical
+         * to prevent connecting to parallels dispatcher */
+        parallelsGetBridgedNetInfo(def, jobj);
+
     } else if (STREQ(tmp, "host-only")) {
         def->forward.type = VIR_NETWORK_FORWARD_NONE;
 
-- 
1.7.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]