On Tue, Jan 06, 2009 at 04:38:12PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > > There are a number of problems breaking the windows / mingw > > build currently. > > > > - Use of 'close' without importing unistd.h > > - Use of non-existant localtime_r > > - ERROR macro from logging.h clashes with a symbol imported > > from windows.h > > > > So this patch does > > > > - Adds the missing unistd.h include > > - Uses localtime() if localtime_r() is missing (as checked from > > configure) > > That all looks fine. > However, since there's an LGPLv2+ gnulib module that provides > localtime_r (called time_r) you may want to skip that part. > Or just go ahead with what you have and I'll undo > things when I've confirmed pulling in the new module works > as expected. I committed everything except the localtime_r() change... Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list