Re: [PATCH 00/12] Implement random number generator hot/cold (un)plug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 06, 2015 at 04:32:14PM +0100, Peter Krempa wrote:
> Extension of Luyao's series with changes that were possible due to the prepare
> series for memory hotplug.
> 
> Luyao Huang (7):
>   qemu: Add helper to assign RNG device aliases
>   qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug
>   qemu: command: Make RNG backend device IDs unique
>   audit: export virDomainAuditRNG
>   conf: Add helpers to insert/remove/find RNG devices in domain def
>   qemu: Implement random number generator hotplug
>   qemu: Implement random number generator hotunplug
> 
> Peter Krempa (5):
>   conf: Introduce helper to find duplicate device address
>   qemu: command: Shuffle around formatting of alias for RNG device
>     backend
>   qemu: command: Break some very long lines in qemuBuildRNGDevStr()
>   qemu: command: Refactor creation of RNG device commandline
>   qemu: Implement random number generator cold (un)plug
> 
>  src/conf/domain_audit.c                            |   2 +-
>  src/conf/domain_audit.h                            |   7 +
>  src/conf/domain_conf.c                             | 164 +++++++++++++++++
>  src/conf/domain_conf.h                             |   8 +
>  src/libvirt_private.syms                           |   6 +
>  src/qemu/qemu_command.c                            | 153 +++++++++++----
>  src/qemu/qemu_command.h                            |   9 +
>  src/qemu/qemu_driver.c                             |  41 ++++-
>  src/qemu/qemu_hotplug.c                            | 205 ++++++++++++++++++++-
>  src/qemu/qemu_hotplug.h                            |   7 +-
>  .../qemuxml2argv-aarch64-virt-virtio.args          |   4 +-
>  .../qemuxml2argv-arm-vexpressa9-virtio.args        |   4 +-
>  .../qemuxml2argv-arm-virt-virtio.args              |   4 +-
>  .../qemuxml2argv-s390-piix-controllers.args        |   3 +-
>  .../qemuxml2argv-s390-usb-none.args                |   3 +-
>  .../qemuxml2argv-virtio-rng-ccw.args               |   4 +-
>  .../qemuxml2argv-virtio-rng-default.args           |   4 +-
>  .../qemuxml2argv-virtio-rng-egd.args               |   4 +-
>  .../qemuxml2argv-virtio-rng-multiple.args          |   8 +-
>  .../qemuxml2argv-virtio-rng-random.args            |   4 +-
>  20 files changed, 578 insertions(+), 66 deletions(-)
> 

ACK series, see my replies to individual patches for some minor nits.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]