On 02/06/2015 09:19 AM, Stefan Zimmermann wrote: > If you will build libvirt with the no-git-option than you is the > gnulib-srcdir mandatory. You will lose this information till now. With > this patch you will save this information. Still an awkward read; I've adjusted it as follows: If you build libvirt with the --no-git option, then gnulib requires either $GNULIB_SRCDIR in the environment or --gnulib-srcdir on the command line. But we had not been supporting its use from the command line. This patch is a bit picky: --gnulib-srcdir must be passed immediately after --no-git; but since we don't reorder arguments, and since we already required --no-git to be first to have any effect, it's not too horrible. > > Signed-off-by: Stefan Zimmermann <stzi@xxxxxxxxxxxxxxxxxx> > --- > autogen.sh | 4 ++++ > 1 file changed, 4 insertions(+) ACK and pushed. Congrats on your first libvirt patch! > > diff --git a/autogen.sh b/autogen.sh > index 1965f64..d1c319d 100755 > --- a/autogen.sh > +++ b/autogen.sh > @@ -20,6 +20,10 @@ no_git= > if test "x$1" = "x--no-git"; then > no_git=" $1" > shift > + case "$1 $2" in > + --gnulib-srcdir=*) no_git="$no_git $1"; shift ;; > + --gnulib-srcdir\ *) no_git="$no_git $1=$2"; shift; shift;; > + esac > fi > if test -z "$NOCONFIGURE" ; then > if test "x$1" = "x--system"; then > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list