Re: [PATCH] qemu: Properly report error when cookin uuid not match the ctxt uuid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/05/2015 03:14 PM, Ján Tomko wrote:
On Thu, Feb 05, 2015 at 11:42:26AM +0800, Luyao Huang wrote:
Add the missing jump to the error label when cookin uuid
does not match the ctxt uuid.

'cookie uuid' and 'ctxt uuid' don't seem clear enough to me.
I have reworded the commit message:

Add the missing jump to the error label when the uuid in the
migration cookie XML does not match the uuid of the migrated
domain.

Okay, thanks for rewording the message.
Signed-off-by: Luyao Huang <lhuang@xxxxxxxxxx>
---
  src/qemu/qemu_migration.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 8a8fa63..879b1bf 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1147,6 +1147,7 @@ qemuMigrationCookieXMLParse(qemuMigrationCookiePtr mig,
          virReportError(VIR_ERR_INTERNAL_ERROR,
                         _("Incoming cookie data had unexpected UUID %s vs %s"),
                         tmp, uuidstr);
+        goto error;
      }
      VIR_FREE(tmp);
ACK and pushed.

Thanks.
Jan

Luyao

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]