Re: [PATCH 0/2] schemas: Remove useless definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 30, 2015 at 06:55:05AM +0100, Martin Kletzander wrote:
Let's save 21 lines just because I've found out a way how to convince
xmllint to do something we thought it can't.  The first patch is the
brains of this operation, the second one is just a cleaner guy; best
served with '-w'.


Oh, never mind, NACK this.  The problem is one story deeper.  For
those interested:

With these patches, one type of XML still fails to validate; those
where e.g. <vlan/> comes before <virtualport/>.  That is most likely
caused by virtualPortProfile being enclosed in <interleave/> with
<source/>.  If I were to remove that, we'd be validating perfectly,
*but* it would be invalid to have <source/> after <virtualport/>.

In other words, if you have a group and elements in that group can
interleave, the group can interleave with other options only as a
group (no element it can interleave with can be placed inside that
group) -- that makes sense, until...
If, however, elements in that group cannot interleave, it means that
those elements must be specified in the same exact order, *but*
elements the whole group can interleave with *can* be specified inside
that group without any problems.

I should've just listened to Michal and leave it like that.  xmllint-- rng--

Martin Kletzander (2):
 schema: Remove unnecessary interface-options
 schema: Indent interface properly

docs/schemas/domaincommon.rng | 787 ++++++++++++++++++++----------------------
1 file changed, 383 insertions(+), 404 deletions(-)

--
2.2.2

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: pgppTa3On9xy8.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]