Re: [PATCH 3/7] virfile: Need to check for ENOTCONN from recvfd failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/28/2015 03:25 PM, John Ferlan wrote:
> A gnulib change (commit id 'beae0bdc') causes ENOTCONN to be returned
> from recvfd which causes us to fall into the throwaway waitpid() call
> and return ENOTCONN to the caller, this then gets displayed during
> a 'virsh save' when using a root squashed NFS environment that's trying
> to save the file as something other than root:root.
> 
> This patch will add the additional check for ENOTCONN to force the code
> into the waitpid loop looking for the actual status from the _exit()'d
> child fork.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/util/virfile.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

ACK.  It goes away in your later bigger patch, but doing this makes
backports of a trivial fix without the risk of a refactor bug easier.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]