On Thu, Jan 22, 2015 at 10:28:19 +0800, Luyao Huang wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1164627 > > Add a func just check the base target type which > qemu support. And this check will help to avoid add a qemu > unsupport target type chr device to a running guest(hotplug) > or to the guest inactive XML (coldplug, will effect next boot) You can get exactly the same behavior adding the device by specifying a new XML containing the device (via virsh edit for example). Unfortunately the unsupported devices can't be checked in the post parse callback as it would make existing VMs with broken config disappear. Additionally even if you forbid known-bad targets you still even with this code can get a failure by adding a SCLP console on a x86 machine: <console type='pty'> <target type='sclp' port='0'/> </console> Starting such VM gets you: error: unsupported configuration: sclp console requires QEMU to support s390-sclp This kind of failure depends on the actual qemu process running the VM and can be checked only when the VM is starting. > > And this check only check the target type, and other things > have been checked in virDomainChrDefParseXML. > > Signed-off-by: Luyao Huang <lhuang@xxxxxxxxxx> > --- > src/libvirt_private.syms | 2 ++ > src/qemu/qemu_hotplug.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 69 insertions(+) > Said this. I don't think it's worth adding the check to the coldplug path. Peter
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list