Hello, On Tue, 2015-01-13 at 17:00 +0000, Daniel P. Berrange wrote: > +# define VIR_WARNINGS_NO_PRINTF \ > + _Pragma ("GCC diagnostic push") \ > + _Pragma ("GCC diagnostic ignored \"-Wsuggest-attribute=format\"") Xen automated tests are failing to build on all architectures with: util/virxml.c: In function 'catchRNGError': util/virxml.c:1094:9: error: unknown option after '#pragma GCC diagnostic' kind [-Werror=pragmas] which I think must be down to one of these additions. (helpful of gcc not to print the unknown option in question!) test overview: http://www.chiark.greenend.org.uk/~xensrcts/logs/33443/ specific failure log: http://www.chiark.greenend.org.uk/~xensrcts/logs/33443/build-amd64-libvirt/5.ts-libvirt-build.log We use Debian Wheezy's gcc, which is 4.6.3 AFAIK. Cheers, Ian. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list