Re: [PATCH] qemu: fix fail to start vm with one cell use memdev and another not

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 01/16/2015 04:48 PM, Peter Krempa wrote:
On Fri, Jan 16, 2015 at 10:12:49 +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1182467

We changed our build numa qemu cmd line way in f309db,
But qemu cannot accept one cell use memdev and another not,
so this cause a issue when we start a vm with one cell
have hugpage or nodemask settings and others not.

After this patch we will use memdev for all cells if there
is at least one cell need this.

Signed-off-by: Luyao Huang <lhuang@xxxxxxxxxx>
---
  src/qemu/qemu_command.c                            | 88 +++++++++++++---------
  .../qemuxml2argv-numatune-memnode-no-memory.args   |  3 +-
  2 files changed, 55 insertions(+), 36 deletions(-)

I'm currently refactoring this piece of code and this patch would be
mostly reverted and reworked in the end, thus I'm not going to commit it
and I'll fix the bug in the new code after I'm finished with the
refactors.

Thanks for the patch though.

No problem, i am looking forward your patch:)

Peter

Luyao

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]