Re: [PATCHv2 6/7] domain_conf: Resolve Coverity RESOURCE_LEAK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
> From: John Ferlan <jferlan@xxxxxxxxxx>
>
> Commit id 'aa2cc721' added call to virSocketAddrFormat
> and did not VIR_FREE() the returned memory.
>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 3c5f279..d262d72 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -17198,6 +17198,7 @@ virDomainNetIpsFormat(virBufferPtr buf, virDomainNetIpDefPtr *ips, size_t nips)
>              familyStr = "ipv4";
>          virBufferAsprintf(buf, "<ip address='%s'",
>                            ipStr);
> +        VIR_FREE(ipStr);
>          if (familyStr)
>              virBufferAsprintf(buf, " family='%s'", familyStr);
>          if (ips[i]->prefix != 0)

ACK.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]