Re: [PATCH v2 08/11] Decouple CPU XML formatting from domain XML public API flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 08, 2015 at 15:48:19 +0000, Daniel Berrange wrote:
> The virCPUDefFormat* methods were relying on the VIR_DOMAIN_XML_*
> flag definitions. It is not desirable for low level internal
> functions to be coupled to flags for the public API, since they
> may need to be called from several different contexts where the
> flags would not be appropriate.
> ---
>  src/conf/capabilities.c |  2 +-
>  src/conf/cpu_conf.c     | 14 +++++++-------
>  src/conf/cpu_conf.h     |  6 +++---
>  src/conf/domain_conf.c  |  3 ++-
>  src/cpu/cpu.c           |  2 +-
>  tests/cputest.c         | 11 +++++------
>  6 files changed, 19 insertions(+), 19 deletions(-)

ACK

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]