On 01/07/2015 10:42 AM, Ján Tomko wrote: > Patches 3-8 fix possible crash/invalid memory access if QEMU crashes > while we're in the monitor. > Patches 9-13 change all other callers of qemuDomainObjExitMonitor > to exit early in that case, but should not fix any real issues. > They are necessary to turn on ATTRIBUTE_RETURN_CHECK for the ExitMonitor > call. > My brain has saturated in the middle of patch 12.... I'll pick this up in the morning John > https://bugzilla.redhat.com/show_bug.cgi?id=1161024 > > Ján Tomko (14): > Check for domain liveness in qemuDomainObjExitMonitor > Mark the domain as active in qemuhotplugtest > Fix vmdef usage after domain crash in monitor on device removal > Fix vmdef usage after domain crash in monitor on device detach > Fix vmdef usage after domain crash in monitor on device attach > Fix vmdef usage while in monitor in qemuDomainHotplugVcpus > Fix vmdef usage while in monitor in BlockStat* APIs > Fix vmdef usage while in monitor in qemu process > Exit early after domain crash in monitor on device hotplug > Exit early after domain crash in monitor on migration > Exit early after domain crash in monitor in qemu_process > Exit early after domain crash in monitor in qemu_driver > Exit early after domain crash in monitor on snapshots > Add ATTRIBUTE_RETURN_CHECK to qemuDomainObjExitMonitor > > src/qemu/THREADS.txt | 5 ++ > src/qemu/qemu_domain.c | 27 +++++-- > src/qemu/qemu_domain.h | 7 +- > src/qemu/qemu_driver.c | 196 +++++++++++++++++++++++++++++----------------- > src/qemu/qemu_hotplug.c | 183 ++++++++++++++++++++++++++----------------- > src/qemu/qemu_hotplug.h | 6 +- > src/qemu/qemu_migration.c | 137 ++++++++++++++++---------------- > src/qemu/qemu_process.c | 128 +++++++++++++++++------------- > tests/qemuhotplugtest.c | 6 ++ > 9 files changed, 410 insertions(+), 285 deletions(-) > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list