Re: [PATCH v4 1/2] src/Makefile: move the new xen_xl_disk parser code at the correct place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/08/2015 06:20 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  src/Makefile.am | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)

>  
>  if WITH_XENCONFIG
> +AM_LFLAGS = -Pxl_disk_ --header-file=../$*.h

Uggh.  Not your fault (this patch was just code motion), but it
highlights a portability problem: RHEL 5 ships with flex 2.5.4, which
lacks --header-file, and which spells --outfile only as -o.  The build
is failing with:

flex  -Pxl_disk_
--header-file=/home/dummy/libvirt/src/xenconfig/xen_xl_disk.h
--outfile=/home/dummy/libvirt/src/xenconfig/xen_xl_disk.c
xenconfig/xen_xl_disk.l
flex: unknown flag '-'.  For usage, try
        flex --help

As far as I know, we are still aiming to allow for out-of-the-box
compilation on RHEL 5 hosts, so I'm looking at fixing this.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]