Re: [PATCH] maint: in makefiles, $(top_srcdir)/src is verbose

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/08/2015 02:25 AM, Michal Privoznik wrote:
> On 08.01.2015 01:07, Eric Blake wrote:
>> I noticed this while working on the previous commit.  Why should
>> we be calling out '../src/' when it is sufficient to refer to just
>> './'?  Blind copy-and-paste runs rampant in this file :)
>>
>> * src/Makefile.am (INCLUDES, *_CFLAGS): Shorten to $(srcdir).
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>>
>> I'll wait for a review on this one.  Let me know if I should redo
>> the patch to keep trailing \ lined up in the sections where it
>> started as aligned...
>>
>>   src/Makefile.am | 112
>> ++++++++++++++++++++++++++++----------------------------
>>   1 file changed, 56 insertions(+), 56 deletions(-)
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]