On Tue, Jan 06, 2015 at 10:28:13AM -0700, Eric Blake wrote: > On 01/06/2015 09:12 AM, Wei Liu wrote: > > Currently libxl driver hardcodes some paths in its capability string, > > which might not be the correct paths. > > > > This patch introduces --with-libxl-prefix, so that user can specify the > > prefix used to build Xen tools. The default value is /usr/local which is > > the default --prefix for Xen tools. > > Why can't you just make '--with-libxl=/path/to/alt' work? That is, > --with-libxl=yes uses a default (which matches the prefix where LIBVIRT > will be installed [1]), --with-libxl=no turns it off, and specifying a > path says to use that path. Then you don't need to add a new option. > But --with-libxl is used to specify build time path which can be different from runtime path if I build libvirt against a non-installed version of xen. Consider I have a non-installed build of libxl in /local/scratch/xen.git/dist/install/usr/local but not /usr/local. I don't want that "/local/scratch..." end up in capability string. Wei. > [1] The assumption generally is that whoever is building libvirt has > also built libxl to be installed in the same location - which is a nicer > default than hard-coding a /usr/local default that libxl uses in > isolation. Of course, libvirt also defaults to /usr/local in isolation, > so if you don't specify anything at all, then ./configure will see that > libvirt is going into /usr/local and will therefore default to looking > for libxl also in /usr/local; but for a distro packager, it is nicer to > have the mere specification of --prefix switch all other relative > defaults to play nicely with everything else in the distro. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list