Re: [PATCHv5 08/18] IP doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 30, 2014 at 11:27:17AM +0100, Cédric Bosdonnat wrote:
> ---
>  docs/formatdomain.html.in | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 9261f24..a17cd8b 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -4328,18 +4328,19 @@ qemu-kvm -net nic,model=? /dev/null
>      <interface type='network'>
>        <source network='default'/>
>        <target dev='vnet0'/>
> -      <b>&lt;ip address='192.168.122.5' prefix='24'/&gt;</b>
> +      <b>&lt;ip family='ipv4' address='192.168.122.5' prefix='24'/&gt;</b>
>      &lt;/interface&gt;
>    &lt;/devices&gt;
>    ...
>  </pre>
>  
>      <p>
> -    <span class="since">Since 1.2.10</span> the network devices can be provided
> -    zero or more IP addresses to set
> +    <span class="since">Since 1.2.12</span> the network devices and host devices
> +    with network capabilities can be provided zero or more IP addresses to set
>      on the target device. Note that some hypervisors or network device types
> -    will simply ignore them or only use the first one. The <code>address</code>
> -    attribute can hold either an IPv4 or IPv6 address. The <code>prefix</code>
> +    will simply ignore them or only use the first one. The <code>family</code>
> +    attribute can be set to either <code>ipv4</code> or <code>ipv6</code>, the
> +    <code>address</code> attribute holds the IP address. The <code>prefix</code>
>      is not mandatory since some hypervisors do not handle it.
>      </p>

ACK, but this should be squashed into the previous patch before pushing
to GIT

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]