Re: [PATCH v2] test: fix nwfilter tests following changes in virfirewall.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 22, 2014 at 10:26:01AM -0500, Stefan Berger wrote:
On 12/22/2014 04:37 AM, Martin Kletzander wrote:
On Sun, Dec 21, 2014 at 10:52:39AM -0500, Stefan Berger wrote:
On 11/26/2014 11:53 AM, Eric Blake wrote:
On 11/26/2014 09:26 AM, Stefan Berger wrote:
Some of the nwfilter tests are now failing since --concurrent shows
up in the ebtables command. To avoid this, implement a function
preventing the probing for lock support in the eb/iptables tools
and use it in the tests.
Now that I've read Martin and Prerna's exchange, I'm wondering if we
should instead make this override force the locking flags ON, and
adjust
the expected test output to expect the -w/--concurrent.


Either this or the other patch should have made it into v1.2.11...


I was under the impression that it did.  As I said earlier, changing
tests to always use concurrent is a long run, not a simple "sed -i
..." or something.

And I don't feel like it's of a huge importance as I, for example,
have around 3 other tests failing when building as root.

On Fedora 20 I get 3 skips and 2 failures. The 2 failures are solved by
the posted patch.


ACK for this version if it fixes all problems on F20.  I need to check
why it still fails for me though, but that's nothing that should
concern you.

Martin

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]