On Thu, Dec 18, 2008 at 10:26:07AM +0100, Guido G?nther wrote: > Hi, > due to some restructuring we free the device structure so devices are > plugged correctly but "dumpxml" fails since the dev structure is already This is a rather over complicated way of fixing it. Why not just do: < cleanup: < virDomainDeviceDefFree(dev) ----------------- > cleanup: > if (ret < 0) > virDomainDeviceDefFree(dev); Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list