Re: [PATCH v2 08/12] getstats: report block sizes for offline domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/2014 08:03 AM, Peter Krempa wrote:
> On 12/16/14 09:04, Eric Blake wrote:
>> The prior refactoring can now be put to use. With the same domain
>> as the previous commit (one qcow2 disk and an empty cdrom drive):
>> $ virsh domstats --block foo
>> Domain: 'foo'
>>   block.count=2
>>   block.0.name=hda
>>   block.0.allocation=200704
>>   block.0.capacity=42949672960
>>   block.0.physical=200704
>>   block.1.name=hdc
>>
>> * src/qemu/qemu_driver.c (qemuStorageLimitsRefresh): Tweak
>> semantics of helper function.

This was actually simplified in earlier patches, and no longer needed
tweaking.

>> (qemuDomainGetStatsBlock): Use it to report offline statistics.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>>  src/qemu/qemu_driver.c | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>>
> 
> ACK,

Will push shortly, after updating the commit message to be accurate (I
originally wrote it before block.0.path was implemented, but rebasing
let that addition go in earlier).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]