Re: [PATCH] Buffer size too small when reading sysinfo on S390

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/15/2014 07:02 PM, Eric Blake wrote:
On 12/15/2014 06:57 AM, Jiri Denemark wrote:
On Mon, Dec 15, 2014 at 14:16:31 +0100, Boris Fiuczynski wrote:
On a system with 160 CPUs the /proc/cpuinfo size grows beyond
the currently set limit of 10KB causing an internal error.

This patch increases the buffer size for S390 to 64KB.



I don't think this needs to be S390 specific. Why can't we just increase
CPUINFO_FILE_LEN to, e.g., 1MB?

I tend to agree; it shouldn't hurt to make the limit larger for everyone.

OK, I have no problem doing that. Not sure if we want to really go up to 1MB. Doing some quick calculation: 1 MB would result in more than 1,500 CPUs on x86 and more than 13,000 CPUs on S390. Well, at least it will for sure be large enough for some time. :)

--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]