Re: [PATCH 2/3] qemu: Free saved error in qemuDomainSetVcpusFlags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/2014 12:13 PM, Martin Kletzander wrote:
> Commit e3435caf added cleanup code to qemuDomainSetVcpusFlags() that was
> not supposed to reset the error.  Usual procedure was done, saving the
> error to temporary variable, but it was never free'd, but rather leaked.
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 1 +
>  1 file changed, 1 insertion(+)

ACK

> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 7211d42..9aba4c8 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -4781,6 +4781,7 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus,
>          err = virSaveLastError();
>          virCgroupSetCpusetMems(cgroup_temp, mem_mask);
>          virSetError(err);
> +        virFreeError(err);
>      }
> 
>      if (!qemuDomainObjEndJob(driver, vm))
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]