Re: [PATCH 0/2] Refactor safezero and virStorageFileResize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15.12.2014 22:13, John Ferlan wrote:
Originally included as part of a series to fix a problem with file creation
and resize within NFS storage pools that ended up being an issue somewhere
lower in the stack of posix_fallocate or the setting of the block size in
the meta data.  The following two patches extract out the refactoring of
safezero and reworking virStorageFileResize to utilize safezero instead.

Original series and review comments for comparison:

http://www.redhat.com/archives/libvir-list/2014-August/msg00491.html

I figured rather than lose any of the code and there is some value in
utilizing the same code in order to handle a similar function that I'd
repost as a separate series.

John Ferlan (2):
   virfile: Refactor safezero
   virstoragefile: Have virStorageFileResize use safezero

  src/locking/lock_driver_sanlock.c |  4 +--
  src/storage/storage_backend.c     |  2 +-
  src/util/virfile.c                | 63 +++++++++++++++++++++++++++++++++------
  src/util/virfile.h                |  2 +-
  src/util/virstoragefile.c         | 29 ++++++------------
  5 files changed, 67 insertions(+), 33 deletions(-)


ACK to both

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]