Re: [PATCH] spec: Disable -Werror in Fedora RPM builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/15/2014 04:25 PM, Daniel P. Berrange wrote:
> Since we switched to using GIT to apply patches in the RPM spec,
> we automagically also turned on -Werror, since the .git directory
> now exists. We don't want this on in Fedora, since changing
> header files often lead to new warnings being issued. Explicitly
> turn off -Werror for non-RHEL platforms, instead of relying on
> the defaults
> ---
>  libvirt.spec.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 264c06f..edf2df8 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -357,6 +357,8 @@
>  # changes in reported warnings
>  %if 0%{?rhel}
>      %define enable_werror --enable-werror
> +else
> +    %define enable_werror --disable-werror
>  %endif
>  

This breaks 'make rpm' in jenkins:
error: line 360: Unknown tag: else

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]