Re: [PATCH 01/10] parallels: support NULL virDomainVideoAccelDefPtr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 11 December 2014 22:07:08 Dmitry Guryanov wrote:

Sorry. I've sent too many patches. Patches 4-10 should be reworked.

Please, check only first 3 patches.


> I support if virDomainVideoAccelDefPtr is NULL it means
> default values for video acceleration. So we don't need
> to report error.
> ---
>  src/parallels/parallels_sdk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
> index 0b05bc1..0980f50 100644
> --- a/src/parallels/parallels_sdk.c
> +++ b/src/parallels/parallels_sdk.c
> @@ -2029,7 +2029,7 @@ static int
> prlsdkCheckVideoUnsupportedParams(virDomainDefPtr def) return -1;
>      }
> 
> -    if (v->accel == NULL || v->accel->support2d || v->accel->support3d) {
> +    if (v->accel != NULL && (v->accel->support2d || v->accel->support3d)) {
> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>                         _("Parallels Cloud Server doesn't support "
>                           "setting video acceleration parameters."));

-- 
Dmitry Guryanov

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]