Re: [PATCH 1/3] parallels: support NULL virDomainVideoAccelDefPtr

[Maxim Nestratov <mnestratov@xxxxxxxxxxxxx>]

Looks OK

Best,
Maxim Nestratov

---

От: Dmitry Guryanov
Отправлено: ‎10.‎12.‎2014 17:30
Кому: libvir-list@xxxxxxxxxx
Копия: Alexander Burluka; Maxim Nestratov; Dmitry Guryanov
Тема: [PATCH 1/3] parallels: support NULL virDomainVideoAccelDefPtr

I support if virDomainVideoAccelDefPtr is NULL it means
default values for video acceleration. So we don't need
to report error.

Signed-off-by: Dmitry Guryanov <dguryanov@xxxxxxxxxxxxx>
---
 src/parallels/parallels_sdk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
index 0b05bc1..0980f50 100644
--- a/src/parallels/parallels_sdk.c
+++ b/src/parallels/parallels_sdk.c
@@ -2029,7 +2029,7 @@ static int prlsdkCheckVideoUnsupportedParams(virDomainDefPtr def)
         return -1;
     }
 
-    if (v->accel == NULL || v->accel->support2d || v->accel->support3d) {
+    if (v->accel != NULL && (v->accel->support2d || v->accel->support3d)) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("Parallels Cloud Server doesn't support "
                          "setting video acceleration parameters."));
--
1.9.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list