Re: Waiting for review of [PATCH v2 2/21] hyperv: implementation of virConnectGetVersion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/08/2014 03:32 AM, Yves Vinter wrote:
> No answer ???
> 
> What does it mean :
> 
> -        you don't have a window for the review ?

Probably truer than we wish - the biggest bottleneck in open source
projects is review time.

> 
> -        you are not interested in getting these developments ?

To the contrary, we ARE interested. It's just a juggling act between
fixing known bugs in other areas and taking the mental time to review
relatively unfamiliar code.

> 
> -        you don't agree with the delivery process I proposed ?
> 
> -        you prefer getting the whole set of the v2 versions before reviewing ?

At this point, a rebased v2 will probably get reviewed faster than
waiting for someone to jump on v1.

Also, one of the BEST ways to get your code reviewed faster is to return
the favor by reviewing other patches.  Even if you admit that your
review is weak and you'd like a second set of eyes, any review that you
can offer to someone else's patches shows that you are serious about
contributing to the community, and therefore deserve the community's
time to review your patches.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]