Re: [PATCH 09/12] getstats: prepare for dynamic block.count stat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/08/14 15:19, Peter Krempa wrote:
> On 12/06/14 09:14, Eric Blake wrote:
>> A coming patch will make it optionally possible to list backing
>> chain block stats; in this mode of operation, block.counts is no
>> longer the number of <disks> in the domain, but the number of
>> blocks in the array being reported.  We still want block.count
>> listed first, but rather than iterate the tree twice (once to
>> count, and once to list stats), it's easier to just touch things
>> up after the fact.
>>
>> * src/qemu/qemu_driver.c (qemuDomainGetStatsBlock): Compute count
>> after the fact.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>>  src/qemu/qemu_driver.c | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>

Compiler complains:

qemu/qemu_driver.c: In function 'qemuDomainGetStatsBlock':
qemu/qemu_driver.c:18630:46: error: 'i' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         record->params[count_index].value.ui = i;
                                              ^
  CC       lxc/libvirt_driver_lxc_impl_la-lxc_native.lo
  CC       lxc/libvirt_driver_lxc_impl_la-lxc_driver.lo
  CC       uml/libvirt_driver_uml_impl_la-uml_conf.lo
  CC       uml/libvirt_driver_uml_impl_la-uml_driver.lo
  CC       network/libvirt_driver_network_impl_la-bridge_driver.lo
  CC       network/libvirt_driver_network_impl_la-bridge_driver_platform.lo


> 
> ACK,
> 

if you fix the issue above.

> Peter
> 


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]