On Sat, Dec 06, 2014 at 10:11:27AM +0100, Martin Kletzander wrote:
On Fri, Dec 05, 2014 at 09:55:00AM -0700, Eric Blake wrote:On 12/05/2014 03:20 AM, Martin Kletzander wrote:On Fri, Dec 05, 2014 at 09:47:47AM +0000, Ian Campbell wrote:On Tue, 2014-12-02 at 07:50 +0100, Martin Kletzander wrote:That said, I found out that that XML-XPath is only needed when creating the tarball, but (probably) not when building an RPM with it.It's needed when building from the git tree to, Xen automated testing picked up on this overnight: http://www.chiark.greenend.org.uk/~xensrcts/logs/32083/build-amd64-libvirt/5.ts-libvirt-build.log I'm not sure if things which are only needed to build the tarball are supposed to be checked for by configure or not.We didn't check for XHTML DTDs either, so I don't think so, but OTOH I'm fine with adding that there if majority agrees.Ideally, something that is required for building 'make dist' or 'make rpm' should be required by bootstrap (autogen.sh uses bootstrap.conf to require minimum versions of maintainer-only tools); but if they are optional when building from a tarball, then they should not be required by configure (but configure should still check for them, and we should do a better job of cleanly skipping rather than erroring if an optional build component is not present when building from tarball).How can you add a perl module in "buildreq"? I'm not familiar with how bootstrap works.
I had a look at that and posted a patch for gnulib [1] to work with perl modules and additional path for libvirt [2] which takes that into account. Let me see if that works for you. Martin [1] https://lists.gnu.org/archive/html/bug-gnulib/2014-12/msg00108.html [2] https://www.redhat.com/archives/libvir-list/2014-December/msg00399.html
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list