Re: [PATCH 02/12] getstats: improve documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/06/14 09:14, Eric Blake wrote:
> At least with 'virsh domstats --block' on an offline domain, we
> currently output no stats even though we recognize the stat
> category.  Although a later patch will improve this situation,
> it is better to document that this is expected behavior.
> 
> Also, while the current implementation rejects filtering flags
> for virDomainListGetStats, this limitation may be lifted in the
> future and we do not enforce it at the API level.
> 
> * src/libvirt-domain.c (virConnectGetAllDomainStats): Document
> that recognized stats might not be reported.
> (virDomainListGetStats): Likewise, and tweak filtering documentation.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/libvirt-domain.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 

ACK,

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]