Re: [PATCHv2] qemu: process: Refactor reconnecting to qemu processes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/04/14 15:19, Martin Kletzander wrote:
> On Thu, Dec 04, 2014 at 02:40:46PM +0100, Peter Krempa wrote:
>> Move entering the job into the thread to simplify the program flow. Also
>> as the code holds a separate reference to the domain object some
>> conditions can be simplified.
>> ---
>>
>> Notes:
>>    Version 2:
>>    - fix leak of 'data' when not reconnecting
>>
>> src/qemu/qemu_process.c | 161
>> ++++++++++++++++++++++--------------------------
>> 1 file changed, 72 insertions(+), 89 deletions(-)
>>
> 
> You can also remove the qemuDomainObjTransferJob() if you want as that
> existed only because of the reconnect function.
> 
> ACK either way, this looks much simpler now.
>
I've removed qemuDomainObjTransferJob along in this patch and pushed.

Thanks.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]