On Tue, Dec 16, 2008 at 06:48:56PM -0800, john.levon@xxxxxxx wrote: > # HG changeset patch > # User john.levon@xxxxxxx > # Date 1229399267 28800 > # Node ID 1f7707a3d49b20397011897cdc04c347322ad0c5 > # Parent a6c317b5fe1b4081ccb40ba90af7d31298cf6b44 > Improve compiler flag checking > > Some compilers (including GCC) don't set the return value consistently > if an erroneous option is passed on the command line. Account for that. This isn't quite correct. We do explicitly need to do a AC_TRY_LINK test, because on Debian there are flags which are accepted by the compiler OK, but will then fail to link. So we should keep the AC_TRY_LINK check, and upon success of that, then also do your additional new check for zero- length stderr output. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list