On 12/02/2014 01:47 PM, Jason Helfman wrote:
On Tue, Dec 2, 2014 at 7:28 AM, Cole Robinson <crobinso@xxxxxxxxxx
<mailto:crobinso@xxxxxxxxxx>> wrote:
On 12/01/2014 08:52 PM, Jason Helfman wrote:
On Fri, Nov 21, 2014 at 10:13 AM, Jason Helfman <jgh@xxxxxxxxxxx
<mailto:jgh@xxxxxxxxxxx>
<mailto:jgh@xxxxxxxxxxx <mailto:jgh@xxxxxxxxxxx>>> wrote:
On Fri, Nov 21, 2014 at 5:09 AM, Cole Robinson
<crobinso@xxxxxxxxxx <mailto:crobinso@xxxxxxxxxx>
<mailto:crobinso@xxxxxxxxxx <mailto:crobinso@xxxxxxxxxx>>> wrote:
On 11/20/2014 11:15 PM, Jason Helfman wrote:
Hello,
I was able to get this imported for FreeBSD, but had to
implement
a couple of
patches for it to work:
https://svnweb.freebsd.org/____ports/head/deskutils/virt-____manager/files/patch-____virtManager_config.py?view=____markup&pathrev=372972
<https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_config.py?view=__markup&pathrev=372972>
<https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_config.py?view=__markup&pathrev=372972
<https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_config.py?view=markup&pathrev=372972>>
https://svnweb.freebsd.org/____ports/head/deskutils/virt-____manager/files/patch-____virtManager_console.py?view=____markup&pathrev=372972
<https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_console.py?view=__markup&pathrev=372972>
<https://svnweb.freebsd.org/__ports/head/deskutils/virt-__manager/files/patch-__virtManager_console.py?view=__markup&pathrev=372972
<https://svnweb.freebsd.org/ports/head/deskutils/virt-manager/files/patch-virtManager_console.py?view=markup&pathrev=372972>>
This was taken obtained from:
https://build.opensuse.org/____package/view_file/openSUSE:____Factory/virt-manager/virt-____manager-Gtk-30.patch#
<https://build.opensuse.org/__package/view_file/openSUSE:__Factory/virt-manager/virt-__manager-Gtk-30.patch#>
<https://build.opensuse.org/__package/view_file/openSUSE:__Factory/virt-manager/virt-__manager-Gtk-30.patch#
<https://build.opensuse.org/package/view_file/openSUSE:Factory/virt-manager/virt-manager-Gtk-30.patch#>>
And is reference by a bug here:
https://bugzilla.suse.com/____show_bug.cgi?id=901869
<https://bugzilla.suse.com/__show_bug.cgi?id=901869>
<https://bugzilla.suse.com/__show_bug.cgi?id=901869
<https://bugzilla.suse.com/show_bug.cgi?id=901869>>
Comments and suggestions are welcome...
Thanks for the heads up. I added a comment in that suse bug
asking for
the patch to be submitted upstream. But if that doesn't
materialize in
a week, ping back here
Any word?
Nope. And looking at the suse RPMs I see a ton of patches that they've
never submitted upstream, some which are clear bug fixes... quite
frustrating. I've attached their patch, can you try it locally and ensure
it fixes your issues? If so I'll push it upstream
Thanks,
Cole
Works great. Thanks!
Thanks for testing, I pushed a variant upstream now:
commit 0b391fe9eda81e6c01ba37171190a8d9b2a51aad
Author: Cole Robinson <crobinso@xxxxxxxxxx>
Date: Tue Dec 2 14:01:28 2014 -0500
virt-manager: Enforce gobject introspection versions
It is too bad that their patches aren't contributed back. My advice is use
their patches (if they work) and note "Obtained from SUSE" in commitlogs. When
their software build process breaks with the next update, they will look at
the logs and find out why. This may encourage them to contribute more to the
project :)
suse benefits from the work of the upstream virt-manager community, least they
can do when they find bugs and write patches is send them to the upstream
mailing list. Requiring the upstream maintainer to go crawling through
downstream RPMs for bug fixes does not scale.
- Cole
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list