Re: [PATCH 02/11] Replace virDomainFree with virObjectUnref

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/01/14 16:56, John Ferlan wrote:
> Since virDomainFree will call virObjectUnref anyway, let's just use that
> directly so as to avoid the possibility that we inadvertently clear out
> a pending error message when using the public API.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  cfg.mk                       |  12 ++++
>  daemon/remote.c              | 131 +++++++++++++++----------------------------
>  src/conf/domain_event.c      |   4 +-
>  src/esx/esx_driver.c         |   2 +-
>  src/hyperv/hyperv_driver.c   |   2 +-
>  src/locking/sanlock_helper.c |   3 +-
>  src/qemu/qemu_driver.c       |   2 +-
>  src/remote/remote_driver.c   |  45 ++++++++-------
>  src/vbox/vbox_common.c       |   6 +-
>  9 files changed, 86 insertions(+), 121 deletions(-)
> 

ACK, the remote driver was okay regarding rewriting of the error,
although few of the *ListAllDomain functions might have the error
overwritten.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]