Re: [PATCH v2 1/5] Introduce virDomainResumeFlags API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/06/14 14:01, Michal Privoznik wrote:
> The old DomainResume API lacks flags argument. This is
> unfortunate, because there may exist some use cases
> where an additional work could be done on domain
> resume. However, without flags it's not possible.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  include/libvirt/libvirt-domain.h |  2 ++
>  src/driver-hypervisor.h          |  5 +++++
>  src/libvirt-domain.c             | 44 ++++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms          |  5 +++++
>  src/remote/remote_driver.c       |  1 +
>  src/remote/remote_protocol.x     | 13 +++++++++++-
>  src/remote_protocol-structs      |  5 +++++
>  7 files changed, 74 insertions(+), 1 deletion(-)
> 


> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index ebf4530..c68c7c0 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x

> @@ -5506,5 +5511,11 @@ enum remote_procedure {
>       * @generate: none
>       * @acl: connect:write
>       */
> -    REMOTE_PROC_NODE_ALLOC_PAGES = 347
> +    REMOTE_PROC_NODE_ALLOC_PAGES = 347,
> +
> +    /**
> +     * @generate: both
> +     * @acl: domain:suspend
> +     */
> +    REMOTE_PROC_DOMAIN_RESUME_FLAGS = 348

You will have merge conflicts here.

>  };
> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index 362baf9..ce9e35d 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -464,6 +464,10 @@ struct remote_domain_suspend_args {
>  struct remote_domain_resume_args {
>          remote_nonnull_domain      dom;
>  };
> +struct remote_domain_resume_flags_args {
> +        remote_nonnull_domain      dom;
> +        u_int                      flags;
> +};
>  struct remote_domain_pm_suspend_for_duration_args {
>          remote_nonnull_domain      dom;
>          u_int                      target;
> @@ -2927,4 +2931,5 @@ enum remote_procedure {
>          REMOTE_PROC_DOMAIN_BLOCK_COPY = 345,
>          REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TUNABLE = 346,
>          REMOTE_PROC_NODE_ALLOC_PAGES = 347,
> +        REMOTE_PROC_DOMAIN_RESUME_FLAGS = 348,
>  };
> 

ACK,

Peter

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]