On 11/18/14, 2:25 PM, "Vasiliy Tolstov" <v.tolstov@xxxxxxxxx> wrote: >2014-11-18 21:03 GMT+03:00 Anirban Chakraborty <abchak@xxxxxxxxxxx>: >> I was wondering as well if this patch looks fine and ready for merge. >> Michal, Laine, any thoughts ? > > >Also its not compiled with 1.2.9.1 =( > >/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_hotplug.c: In function >'qemuDomainDetachControllerDevice': >/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_hotplug.c:3240:5: warning: >passing argument 1 of 'virDomainNetGetActualType' from incompatible >pointer type [enabled by default] >In file included from >/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_conf.h:31:0, > from >/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_hotplug.h:27, > from >/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_hotplug.c:27: >/tmp/buildd/libvirt-1.2.9.1/./src/conf/domain_conf.h:2479:5: note: >expected 'virDomainNetDefPtr' but argument is of type >'virDomainControllerDefPtr' >/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_hotplug.c:3241:39: error: >'virDomainControllerDef' has no member named 'ifname' >/tmp/buildd/libvirt-1.2.9.1/./src/qemu/qemu_hotplug.c:3242:9: error: >'virDomainControllerDef' has no member named 'ifname' >make[4]: *** [qemu/libvirt_driver_qemu_impl_la-qemu_hotplug.lo] Error 1 Thanks for pointing out, it was compiled with earlier tip. I¹ll send an updated patch based on the latest git commit. Anirban -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list