Re: [PATCH v2 4/4] qemu-command: introduce new vgamem attribute for video devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
> +        if (video->vram % 1024) {
> +            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> +                           "%s", _("value for 'vram' must be multiple
> of 1024"));
> +            goto error;
> +        }

pci bar size must be a power of two.  Especially the 9216 default value
libvirt fills in there is *not* valid.  This probably needs some extra
care to handle so existing guest xml files don't blow up things.

cheers,
  Gerd


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]