[PATCH v2 01/22] virt-aa-helper: Trick invalid syntax-check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rule sc_prohibit_newline_at_end_of_diagnostic for syntax-check does
check for passing strings ending with '\n' to known functions.  But when
setting IFS, '\n' needs to be part of that (and is by default).  The
order of individual characters in IFS doesn't matter, so transposing
last two of them fixes it for the future.

Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
---
 src/security/virt-aa-helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index 1f299a0..e102c3c 100644
--- a/src/security/virt-aa-helper.c
+++ b/src/security/virt-aa-helper.c
@@ -1257,7 +1257,7 @@ main(int argc, char **argv)
         vah_error(ctl, 1, _("could not set PATH"));
     }

-    if (setenv("IFS", " \t\n", 1) != 0) {
+    if (setenv("IFS", " \n\t", 1) != 0) {
         vah_error(ctl, 1, _("could not set IFS"));
     }

-- 
2.1.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]