On Wed, Nov 12, 2014 at 01:28:38PM +0100, Michal Privoznik wrote: > As I was reviewing bhyve commits, I've noticed qemuxml2argvtest > failing for some test cases. This is not bug in qemu driver code > rather than being unable to load qemuxml2argvmock on non-Linux > platforms. For instance: > > 318) QEMU XML-2-ARGV numatune-memnode > ... libvirt: error : internal error: NUMA node 0 is unavailable > FAILED > > Rather than disabling qemuxml2argvtest on BSD (we do compile qemu > driver there) disable only those test cases which require mocking. > To achieve that goal new DO_TEST_LINUX() macro is introduced which > invokes the test case on Linux only and consume arguments on other > systems. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > tests/qemuxml2argvtest.c | 31 +++++++++++++++++++++++++------ > 1 file changed, 25 insertions(+), 6 deletions(-) ACK, though as a general point it should be possible todo this mocking on any platform using ELF libraries - IOW, anywhere except Windows. So it'd be nice to figure out why it doesn't work on BSD Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list