On Mon, Dec 15, 2008 at 07:40:05PM +0100, Guido G?nther wrote: > On Mon, Dec 15, 2008 at 11:15:53AM +0000, Daniel P. Berrange wrote: > > On Fri, Dec 12, 2008 at 07:26:06PM +0100, Guido G?nther wrote: > > > @@ -870,6 +874,9 @@ int qemudBuildCommandLine(virConnectPtr conn, > > > ADD_ARG_LIT("-monitor"); > > > ADD_ARG_LIT("pty"); > > > > > > + ADD_ARG_LIT("-pidfile"); > > > + ADD_ARG(pidfile); > > > + > > > > Not all versions of QEMU support the -pidfile argument. We'll have to add > > another probe to qemudExtractVersionInfo() method as we do for -drive, > > -uuid, etc. > I skipped this since -pidfile got introduced 2004 already with: Opps, my mistake - it was -daemon that was added in 0.9.0, not -pidfile > svn://svn.savannah.nongnu.org/qemu/trunk@1166 > > Do we really support that old qemu? No, 0.8.2 is the first version I intended it to work with, since that's what was in Fedora 6 / EPEL-5 when I wrote QEMU driver. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list