Re: [v2 PATCH] doc: Fix a mismatch attribute name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/07/2014 10:47 AM, Eric Blake wrote:
> On 11/07/2014 10:35 AM, Luyao Huang wrote:
>> >From virAccessDriverPolkitCheckInterface function, we know this
>> attribute should named: interface_macaddr

Eww. 'git am' strips an initial commit line beginning with ">From ", if
it doesn't match an email address (this is because it special cases a
leading 'From: ...' or '>From: ...' line as overriding commit authorship
instead of using the email's sender as the author).  I didn't realize
that I lost a line of your commit message until after I had pushed my
modifications.

In the future, try to avoid using "From" as the first word of a commit
message.  "Based on the" could serve as an appropriate substitute phrase
for this case.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]